Fix MessageListView rotation crash and custom messagesStart not being applied by gpunto · Pull Request #6438 · GetStream/stream-chat-android

gpunto · 2026-05-14T11:14:25Z

Goal

Fix a MessageListView crash on configuration change (e.g. rotation) when the activity restores its state into a list that gets submitted before the layout pipeline has settled:

IllegalArgumentException: Tmp detached view should be removed from RecyclerView before it can be recycled

The race was reliably reproducible in the sample app with app:streamUiMessagesStart="top": open a channel, open the create-poll dialog, fill title/options, then rotate.

While debugging, also fixed a second bug: setting messagesStart via TransformStyle.messageListStyleTransformer (the customer-facing API) didn't actually apply.

Implementation

Stop swapping chatMessagesRV's height between MATCH_PARENT and WRAP_CONTENT based on MessagesStart. Both modes now use the inflated MATCH_PARENT × MATCH_PARENT. The TOP vs BOTTOM anchoring is expressed via LinearLayoutManager.stackFromEnd instead, which gives the same visual result without re-measuring the RV on every onBindViewHolder. The repeated re-measure cascade was what produced the animator/recycler race.
Call chatMessageStart after initRecyclerView in init, so the layout manager exists when the style is applied. Previously the layout manager was null at that point, the new stackFromEnd-based path returned early, and the configured messagesStart was effectively ignored on first render.

Testing

Verified all four messagesStart / threadMessagesStart combinations via TransformStyle.messageListStyleTransformer in the sample app:

BOTTOM / BOTTOM: main and threads anchored to bottom.
TOP / TOP: main and threads anchored to top.
TOP / BOTTOM and BOTTOM / TOP: mixed anchors render correctly per surface.

For each combination:

Open a channel with many messages: items pack as expected, scrolling unaffected.
Open a channel with few messages: empty space lands on the expected side.
Repeat in a thread.
Repro the original flow (poll as last message → open create-poll dialog → fill title and options → rotate): no crash in any combination.

Summary by CodeRabbit

Bug Fixes
- Improved message list initialization order to ensure proper layout configuration when messages start at the top or bottom.
Refactor
- Optimized message list layout handling logic for better consistency and performance.

… applied

github-actions · 2026-05-14T11:14:43Z

PR checklist ✅

All required conditions are satisfied:

Title length is OK (or ignored by label).
At least one pr: label exists.
Sections ### Goal, ### Implementation, and ### Testing are filled (or ignored for dependabot PRs).

🎉 Great job! This PR is ready for review.

github-actions · 2026-05-14T11:23:30Z

SDK Size Comparison 📏

SDK	Before	After	Status
stream-chat-android-client	5.26 MB	5.26 MB	🟢
stream-chat-android-offline	5.49 MB	5.49 MB	🟢
stream-chat-android-ui-components	10.64 MB	10.65 MB	🟢
stream-chat-android-compose	12.87 MB	12.87 MB	🟢

sonarqubecloud · 2026-05-14T11:27:32Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

coderabbitai · 2026-05-14T13:41:23Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: e720d672-b344-46cc-8b0c-8b383e09193f

📥 Commits

Reviewing files that changed from the base of the PR and between 99a0274 and cda94af.

📒 Files selected for processing (1)

stream-chat-android-ui-components/src/main/kotlin/io/getstream/chat/android/ui/feature/messages/list/MessageListView.kt

Walkthrough

MessageListView adjusts initialization order and refactors layout configuration: initRecyclerView() now runs before applying message-start layout, LinearLayoutManager no longer hard-codes stackFromEnd = true, and changeLayoutForMessageStart() consolidates stackFromEnd and overScrollMode updates based on message start position.

Changes

Message List Layout Initialization

Layer / File(s)	Summary
Deferred stackFromEnd initialization and layout configuration `stream-chat-android-ui-components/src/main/kotlin/io/getstream/chat/android/ui/feature/messages/list/MessageListView.kt`	Init() reorders calls so `initRecyclerView()` runs before `chatMessageStart` layout config is applied; `initRecyclerView()` creates `LinearLayoutManager` without configuring `stackFromEnd`; `changeLayoutForMessageStart()` is rewritten to check for `LinearLayoutManager`, then update `stackFromEnd` and `overScrollMode` conditionally based on `MessagesStart.BOTTOM` or `MessagesStart.TOP`, removing prior `layoutParams` adjustments.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Poem

🐰 A rabbit hops through layout code with glee,
Reordering init calls—stackFromEnd set free!
No more hard-coded scroll, but deferred with care,
Layout configuration blooms in the air! 🌿

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the two main issues fixed: a rotation crash and the custom messagesStart configuration not being applied.
Description check	✅ Passed	The description provides a comprehensive Goal, detailed Implementation, and thorough Testing section. However, it lacks UI Changes (screenshots/videos) and the completed Contributor Checklist required by the template.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/v6/message-list-crash

Tip

💬 Introducing Slack Agent: The best way for teams to turn conversations into code.

Slack Agent is built on CodeRabbit's deep understanding of your code, so your team can collaborate across the entire SDLC without losing context.

Generate code and open pull requests
Plan features and break down work
Investigate incidents and troubleshoot customer tickets together
Automate recurring tasks and respond to alerts with triggers
Summarize progress and report instantly

Built for teams:

Shared memory across your entire org—no repeating context
Per-thread sandboxes to safely plan and execute work
Governance built-in—scoped access, auditability, and budget controls

One agent for your entire SDLC. Right inside Slack.

👉 Get started

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

stream-public-bot · 2026-05-21T16:10:25Z

🚀 Available in v6.38.0

… applied (#6438)

@gpunto

* Fix MessageListView rotation crash and custom messagesStart not being applied (#6438) * Add configurable character limits and feature toggles for polls (#6435) * Add configurable character limits and feature toggles for polls Introduces PollsConfig to control poll feature availability and enforce character limits on questions and options. Poll features (multiple votes, anonymous voting, suggest options, add comments) can now be hidden or preset with default values through ChatUI.pollsConfig or passed directly to CreatePollDialogFragment. * addressing pr comments * 1. Detekt - Fixed the MaxLineLength violation in PollsConfig.kt:23 by breaking the long comment line 2. Spotless - Applied formatting fixes (added license header to PollFeatureConfig.kt) 3. API Check - Regenerated the API dump file * Update stream-chat-android-ui-components/src/main/kotlin/io/getstream/chat/android/ui/feature/messages/composer/attachment/picker/poll/PollsConfig.kt Co-authored-by: Gianmarco <47775302+gpunto@users.noreply.github.com> * Apply suggestion from @gpunto --------- Co-authored-by: Gianmarco <47775302+gpunto@users.noreply.github.com> * Allow voters to suggest poll options in UI Components (#6439) * Allow voters to suggest poll options in UI Components * Use doAfterTextChanged * Align Compose & XML option name trimming * Apply optionTextLimit to suggest poll option dialog (#6446) * Allow voters to add poll comments in UI Components (#6444) * Allow voters to add poll comments in UI Components * Add missing KDoc and default params * Adjust poll comments commit to develop's APIs - Use UiCommonR for stream_ui_poll_action_view_comments plural - Update StateRegistry imports to client.api.state package * Reformat * Add default value to pollSuggestOptionTextStyle * Init poll suggest option confirm button state from current input * Validate poll text limits at PollsConfig construction * Make SuggestPollOptionDialogFragment internal for consistency * Reapply poll feature visibility on rotation in CreatePollDialogFragment * Add MessageListViewModel test for suggesting a poll option * Add CreatePollViewModel test for config propagation --------- Co-authored-by: Ryan Hurst <106116154+ryanhurststrava@users.noreply.github.com>

Fix MessageListView rotation crash and custom messagesStart not being…

cda94af

… applied

gpunto added the pr:bug Bug fix label May 14, 2026

gpunto marked this pull request as ready for review May 14, 2026 13:37

gpunto requested a review from a team as a code owner May 14, 2026 13:37

andremion approved these changes May 15, 2026

View reviewed changes

gpunto merged commit e3de4b7 into v6 May 18, 2026
21 of 23 checks passed

gpunto deleted the fix/v6/message-list-crash branch May 18, 2026 08:16

stream-public-bot added the released Included in a release label May 21, 2026

gpunto mentioned this pull request May 25, 2026

Port v6 XML poll improvements to develop #6468

Merged

gpunto added a commit that referenced this pull request May 25, 2026

Fix MessageListView rotation crash and custom messagesStart not being…

11cacff

… applied (#6438)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix MessageListView rotation crash and custom messagesStart not being applied#6438

Fix MessageListView rotation crash and custom messagesStart not being applied#6438
gpunto merged 1 commit into
v6from
fix/v6/message-list-crash

gpunto commented May 14, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

github-actions Bot commented May 14, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented May 14, 2026

Uh oh!

sonarqubecloud Bot commented May 14, 2026

Uh oh!

coderabbitai Bot commented May 14, 2026

❌ Failed checks (1 warning)

Uh oh!

Uh oh!

stream-public-bot commented May 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

gpunto commented May 14, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Goal

Implementation

Testing

Summary by CodeRabbit

Uh oh!

github-actions Bot commented May 14, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

PR checklist ✅

Uh oh!

github-actions Bot commented May 14, 2026

SDK Size Comparison 📏

Uh oh!

sonarqubecloud Bot commented May 14, 2026

Quality Gate passed

Uh oh!

coderabbitai Bot commented May 14, 2026

Walkthrough

Changes

Estimated code review effort

Poem

❌ Failed checks (1 warning)

Uh oh!

Uh oh!

stream-public-bot commented May 21, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

gpunto commented May 14, 2026 •

edited by coderabbitai Bot

Loading

github-actions Bot commented May 14, 2026 •

edited

Loading